git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: sparse support in pu

From
Sskillzero@gmail.com <skillzero@gmail.com>
Date
Aug 17, 2009, 09:41 UTC
Message-ID
<2729632a0908170241m415867e6t4286f8bfb6116c26@mail.gmail.com>
In-Reply-To
<alpine.DEB.1.00.0908171113420.4991@intel-tinevez-2-302>

On Mon, Aug 17, 2009 at 2:15 AM, Johannes Schindelin<Johannes.Schindelin@gmx.de> wrote:

Show 27 quoted lines
> Hi,
>
> On Mon, 17 Aug 2009, skillzero@gmail.com wrote:
>
>> On Mon, Aug 17, 2009 at 1:17 AM, Nguyen Thai Ngoc Duy<pclouds@gmail.com> wrote:
>> > On Mon, Aug 17, 2009 at 1:09 PM, <skillzero@gmail.com> wrote:
>> >> 1. Have people decided whether it should be on by default if you have
>> >>    a .git/info/sparse file? I'd definitely like it to be on by
>> >>    default.  When I first tried it, I didn't realize I had to use
>> >>    --sparse to git checkout to get it to use the sparse rules. The
>> >>    same goes for a merge I did that happened to have a file in the
>> >>    excluded area (it included it because I didn't use --sparse to git
>> >>    merge).
>> >
>> > I tend to make it enabled by default too. I have made it stricter to
>> > trigger reading sparse in unpack_trees() -- only do it when
>> > unpack_opts.update is TRUE. This should make it safer to be enabled by
>> > default.
>>
>> Other than it being new and not-widely-tested code, is there any
>> additional risk to having it enabled by default if there are no sparse
>> patterns defined?
>
> I think that in and of itself is reason enough to turn off the feature
> when .git/info/sparse is not present.
>
> It also may have a runtime cost, dunno.
I was thinking that it would effectively do this:
Try to read .git/info/sparse
if valid patterns read
   Sparse is enabled
else (e.g. file missing or nothing but empty lines/comments)
   Sparse is disabled

I wouldn't think there would be any additional cost or risk (other than the extra code to read the .git/info/sparse file) because the result is the same as if sparse had been disabled by being defaulted to off since even in the default off case, it's still a runtime check.

I would think --sparse would really only be useful as a way to negate --no-sparse (i.e. act as if .git/info/sparse didn't exist temporarily).

Previous: Johannes SchindelinNext: Johannes Sixt
Message 5 of 21 in “sparse support in pu”
  1. skillzero@gmail.comAug 17, 2009
  2. Nguyen Thai Ngoc DuyAug 17, 2009
  3. skillzero@gmail.comAug 17, 2009
  4. Johannes SchindelinAug 17, 2009
  5. skillzero@gmail.comAug 17, 2009
  6. Johannes SixtAug 17, 2009
  7. Johannes SchindelinAug 17, 2009
  8. Nguyen Thai Ngoc DuyAug 17, 2009
  9. Nguyen Thai Ngoc DuyAug 17, 2009
  10. Johannes SixtAug 17, 2009
  11. Nguyen Thai Ngoc DuyAug 17, 2009
  12. Johannes SixtAug 17, 2009
  13. Nguyen Thai Ngoc DuyAug 17, 2009
  14. Johannes SchindelinAug 17, 2009
  15. Peter HarrisAug 17, 2009
  16. Johannes SchindelinAug 17, 2009
  17. Peter HarrisAug 17, 2009
  18. Junio C HamanoAug 17, 2009
  19. Johannes SchindelinAug 17, 2009
  20. Nguyen Thai Ngoc DuyAug 17, 2009
  21. James PickensAug 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.