Re: [RFC PATCH v2 1/4] Prevent diff machinery from examining assume-unchanged entries on worktree

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 11, 2009, 01:34 UTC
Message-ID: <fcaeb9bf0908101834n7cc7cfaakbf2d92fe8f32e9b1@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0908101800480.8324@intel-tinevez-2-302>

2009/8/10 Johannes Schindelin <Johannes.Schindelin@gmx.de>:

Show 14 quoted lines

>> +test_expect_success 'setup' '
>> +     echo zero > zero &&
>> +     git add zero &&
>> +     git commit -m zero &&
>> +     echo one > one &&
>> +     echo two > two &&
>> +     git add one two &&
>> +     git commit -m onetwo &&
>> +     git update-index --assume-unchanged one &&
>> +     echo borked >> one &&
>> +     test "$(git ls-files -v one)" = "h one"
>> +'
>
> Maybe use test_commit, to make it more readable?

Thanks. I did not know that (or forgot already). Will use it.

Show 9 quoted lines

>
>> +
>> +test_expect_success 'diff-index does not examine assume-unchanged entries' '
>> +     git diff-index HEAD^ -- one | grep -q 5626abf0f72e58d7a153368ba57db4c673c0e171
>> +'
>> +
>> +# TODO ced_uptodate()
>
> What is this about?

It tests "if (ce_uptodate(ce) || (ce->ce_flags & CE_VALID))" and I was pretty sure it hit ce_uptodate() first, so the second expression was not tested.

-- 
Duy