git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v0 3/3] Build in git-rebase.sh

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
May 25, 2009, 06:34 UTC
Message-ID
<fcaeb9bf0905242334q37ef9a05xa05315639af4daf3@mail.gmail.com>
In-Reply-To
<4A1A37AD.4080309@viscovery.net>
On Mon, May 25, 2009 at 4:16 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 22 quoted lines
> Nguyen Thai Ngoc Duy schrieb:
>> On Sat, May 23, 2009 at 07:26:03PM +1000, Nguyen Thai Ngoc Duy wrote:
>>> On Fri, May 22, 2009 at 05:30:31PM +1000, Nguyen Thai Ngoc Duy wrote:
>>>> 2009/5/22 Johannes Sixt <j.sixt@viscovery.net>:
>>>>> Nguyễn Thái Ngọc Duy schrieb:
>>>>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>>>>> Is it possible for you to test this series on Windows? Many rebase tests
>>>>> fail, but I haven't investigated why.
>>>> I'll try it this weekend.
>>> This patch makes t3*rebase*.sh pass for me except t3412 (more exactly
>>> t3412.8). That test failed even with git-rebase.sh. Hmm... Anyway
>>> could you try again to see what tests still fail?
>>
>> Someone with better Windows knowledge than me should explain how this works. Windows'
>> snprintf() just cuts out the last character in this statement:
>>
>> snprintf(buf, 8, "--%s", "onto"); // result: '--ont', expected: '--onto'
>
> This doesn't happen for me: neither with Windows's original snprintf nor
> with the version from compat/. Are you using the latest msysgit
> environment to compile, i.e. gcc 4.4? There was a change regarding
> SNPRINTF_SIZE_CORR; perhaps that's the culprit?

It could be. I used git.git's next branch, not msys4git or mingw.git repositories.

> I don't undertand what this patch does, anyway. Where is the detail that I
> am missing?

The first vsnprintf() in "onto" case above did not produce " --onto" as it should have been. I tried to recover by filling "str" with the second vsnprintf() in the loop.

Show 5 quoted lines
>> All rebase tests now pass for me on Windows (Vista something, I have
>> yet to find where it hides its "uname" command)
>
> They also pass for me with your earlier fix-up patch, but with or without
> this patch to compat/snprintf.c.
Good to know.
-- 
Duy
Previous: Johannes SixtNext: Johannes Sixt
Message 14 of 21 in “doc/git-rebase.txt: remove mention of multiple strategies”
  1. 1/3 doc/git-rebase.txt: remove mention of multiple strategiesNguyễn Thái Ngọc Duy, May 21, 2009
  2. 2/3 t/t3400-rebase.sh: add more tests to help migrating git-rebase.sh to CNguyễn Thái Ngọc Duy, May 21, 2009
  3. 3/3 Build in git-rebase.shNguyễn Thái Ngọc Duy, May 21, 2009
  4. Jakub NarebskiMay 21, 2009
  5. Nguyen Thai Ngoc DuyMay 21, 2009
  6. Jakub NarebskiMay 21, 2009
  7. Nguyen Thai Ngoc DuyMay 21, 2009
  8. Junio C HamanoMay 21, 2009
  9. Johannes SixtMay 22, 2009
  10. Nguyen Thai Ngoc DuyMay 22, 2009
  11. Nguyen Thai Ngoc DuyMay 23, 2009
  12. Nguyen Thai Ngoc DuyMay 23, 2009
  13. Johannes SixtMay 25, 2009
  14. Nguyen Thai Ngoc DuyMay 25, 2009
  15. Johannes SixtMay 25, 2009
  16. Nguyen Thai Ngoc DuyMay 25, 2009
  17. Nguyen Thai Ngoc DuyMay 25, 2009
  18. Jakub NarebskiMay 21, 2009
  19. Nguyen Thai Ngoc DuyMay 21, 2009
  20. Junio C HamanoMay 21, 2009
  21. 2/3 t/t3400-rebase.sh: add more tests to help migrating git-rebase.sh to CNguyễn Thái Ngọc Duy, May 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.