Re: [PATCH v0 3/3] Build in git-rebase.sh
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- May 21, 2009, 12:29 UTC
- Message-ID
- <200905211429.13831.jnareb@gmail.com>
- In-Reply-To
- <fcaeb9bf0905210344h7ac8e10bx311bf9d714573eeb@mail.gmail.com>
On Thu, 21 May 2009, Nguyen Thai Ngoc Duy wrote:
> 2009/5/21 Jakub Narebski <jnareb@gmail.com>: >> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 18 quoted lines
>> [...] >>> +#define REBASE_ABORT 0x0001 >>> +#define REBASE_CONTINUE 0x0002 >>> +#define REBASE_FORCE 0x0004 >>> +#define REBASE_IGNORE_DATE 0x0008 >>> +#define REBASE_INTERACTIVE 0x0010 >>> +#define REBASE_MERGE 0x0020 >>> +#define REBASE_STAT 0x0040 >>> +#define REBASE_NO_VERIFY 0x0080 >>> +#define REBASE_PRESERVE_MERGES 0x0100 >>> +#define REBASE_ROOT 0x0200 >>> +#define REBASE_SKIP 0x0400 >>> +#define REBASE_VERBOSE 0x0800 >> >> I see misaligns here... > > Hmm.. it's perfectly aligned in complete source form. Probably > because of TABs.
Yes, it is because of using TABs to align (and not only to indent),
and probably because of changing tabstop because of extra character
('+' at beginning). I don't know good solution for this problem.
Show 6 quoted lines
>> [...] >> >> Couldn't you use parseopt also in subcommands? > > I don't understand. You mean parseopt for --continue, --skip and > --abort?
Yes. I don't know if it possible, and if it would make sense, but it seems strange to me having both parseopts in main, and strcmp comparisons for other parts...
-- Jakub Narebski Poland