Re: [PATCH] Make git-commit cleverer - have it figure out whether it needs -a automatically

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Nov 30, 2006, 13:32 UTC
Message-ID: <fcaeb9bf0611300532x77c7fc8aq2ba77ff57b81cc05@mail.gmail.com>
In-Reply-To: <200611301324.04993.andyparkins@gmail.com>

Show 13 quoted lines

> diff --git a/git-commit.sh b/git-commit.sh
> index 81c3a0c..fabfeae 100755
> --- a/git-commit.sh
> +++ b/git-commit.sh
> @@ -265,6 +265,14 @@ $1"
>  done
>  case "$edit_flag" in t) no_edit= ;; esac
>
> +# Clever commit - if this commit would do nothing, then make it an "all"
> +# commit
> +if [ -z "$(git-diff-index --cached --name-only HEAD)" \
> +       -a -z "$amend" -a -z "$only" -a -z "$also" ]; then
> +       echo "Nothing to commit but changes in working tree. Assuming 'git commit -a'"

This is hardly seen as the editor will immediately pop up. Better pause a second or put it in commit template (I'd prefer the latter).

Show 8 quoted lines

> +       all=t
> +fi
> +
>  ################################################################
>  # Sanity check options
>
> --
> 1.4.4.1.g3ece-dirty