Re: [PATCH] Make git-commit cleverer - have it figure out whether it needs -a automatically
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Nov 30, 2006, 16:28 UTC
- Message-ID
- <ekn0ne$nuk$1@sea.gmane.org>
- In-Reply-To
- <200611301501.43436.andyparkins@gmail.com>
Andy Parkins wrote:
Show 14 quoted lines
> Raimund Bauer offered this suggestion (paraphrased): > > "Maybe we could do git-commit -a _only_ if the index matches HEAD, and > otherwise keep current behavior? So people who don't care about the > index won't get tripped up, and when you do have a dirty index, you get > told about it?" > > Johannes Schindelin pointed out that this isn't the right thing to do for > an --amend, so that is checked for. Additionally, it's probably not the > right thing to do if any files are specified with "--only" or > "--include", so they turn this behaviour off as well. > > Nguyen Thai Ngoc Duy asked that git-commit let you know it's done this > by adding an extra comment to the commit message.
Insount on #git pointed out fragility of this solution with respect to adding/removing/moving files, which dirties index (which might not be understood by newbie user: "git commit" used to work, but doesn't work the same when I added some files).
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git