Re: Better visual separation of hunks in `git add -p`

From: Dragan Simic <dsimic@manjaro.org>
Date: Mar 28, 2024, 21:19 UTC
Message-ID: <fc4ede3ecffd33811adca702493c8763@manjaro.org>
In-Reply-To: <xmqqr0fut7di.fsf@gitster.g>

On 2024-03-28 21:43, Junio C Hamano wrote:

Show 20 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
> 
>> Of course, users could pick the right escape sequences for their
>> terminals, but as you already noted, the same configurations could
>> end up being used on different terminals.  For example, even SSHing
>> into a machine using a different SSH client could lead to a mess.
> 
> There is a separate discussion of conditional configuration based on
> environment variable settings, e.g.
> 
>     [includeIf "env:TERM:vt100"]
> 	path = ~/.git-config-bits/vt100
> 
> where the named file might have
> 
>     [prompt] prefix = "\033[H\033[J"
> 
> so it is certainly doable.
> 
> It is a different story if doing so is sensible, of course.

Quite frankly, I think that would be like opening a can of worms. In other words, if we end up implementing support for the "add -P" prefix, allowing the users to do whatever they want with the prefixes would surely be fine, but only if we implement "add -P" at the same time, to already provide a reliable and simple way for clearing the screen.