Re: [PATCH 03/10] ref-filter: add the metas namespace to ref-filter

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 26, 2022, 13:13 UTC
Message-ID: <fc291c07-55e9-64f8-1251-20bd2422024d@gmail.com>
In-Reply-To: <54e559967df55ca314e629b65927a88c7f804a98.1663959324.git.gitgitgadget@gmail.com>

Hi Chris

On 23/09/2022 19:55, Chris Poucet via GitGitGadget wrote:

> From: Chris Poucet <poucet@google.com>
> 
> The metas namespace will contain refs for changes in progress. Add
> support for searching this namespace.

I assume this is to save having to write "refs/metas/" when we want to search for meta commits?

Show 10 quoted lines

> Signed-off-by: Chris Poucet <poucet@google.com>
> --- > diff --git a/ref-filter.h b/ref-filter.h
> index aa0eea4ecf5..064fbef8e50 100644
> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -17,8 +17,10 @@
>   #define FILTER_REFS_BRANCHES       0x0004
>   #define FILTER_REFS_REMOTES        0x0008
>   #define FILTER_REFS_OTHERS         0x0010
> +#define FILTER_REFS_CHANGES        0x0040

It would be nice to keep FILTER_REFS_OTHERS at the end I think (we don't need to worry about abi compatibility), also what happened to 0x0020?

Best Wishes

Phillip

Show 7 quoted lines

>   #define FILTER_REFS_ALL            (FILTER_REFS_TAGS | FILTER_REFS_BRANCHES | \
> -				    FILTER_REFS_REMOTES | FILTER_REFS_OTHERS)
> +				    FILTER_REFS_REMOTES | FILTER_REFS_OTHERS | \
> +				    FILTER_REFS_CHANGES)
>   #define FILTER_REFS_DETACHED_HEAD  0x0020
>   #define FILTER_REFS_KIND_MASK      (FILTER_REFS_ALL | FILTER_REFS_DETACHED_HEAD)
>