Re: [PATCH 03/10] ref-filter: add the metas namespace to ref-filter

From: Chris P <christophe.poucet@gmail.com>
Date: Oct 4, 2022, 09:50 UTC
Message-ID: <CAN84kK=vuvmaPJeVupV-ZN2Cnn_E+9STvxRqEbQc4m3dQbD34w@mail.gmail.com>
In-Reply-To: <fc291c07-55e9-64f8-1251-20bd2422024d@gmail.com>

> I assume this is to save having to write "refs/metas/" when we want to
> search for meta commits?

Yes, though currently it still requires "metas/", I'm trying to figure out how to remove that.

Show 10 quoted lines

> Signed-off-by: Chris Poucet <poucet@google.com>
> --- > diff --git a/ref-filter.h b/ref-filter.h
> index aa0eea4ecf5..064fbef8e50 100644
> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -17,8 +17,10 @@
>   #define FILTER_REFS_BRANCHES       0x0004
>   #define FILTER_REFS_REMOTES        0x0008
>   #define FILTER_REFS_OTHERS         0x0010
> +#define FILTER_REFS_CHANGES        0x0040

> It would be nice to keep FILTER_REFS_OTHERS at the end I think (we don't
> need to worry about abi compatibility), also what happened to 0x0020?

The 0x0020 is listed further below, I don't know why the previous author decided to put them out of order. I've renumbered them as you've requested with the assumption that this data never gets serialized to storage.

> Best Wishes

Thank you for all the feedback!

- simply chris