git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Proposal: tell git a file has been renamed

From
JMJeremy Morton <admin@game-point.net>
Date
Apr 22, 2023, 19:44 UTC
Message-ID
<fbe77ad2-ce65-e6a6-254e-01bf6446d582@game-point.net>
In-Reply-To
<01cd01d9754b$f12326b0$d3697410$@nexbridge.com>

I read that git mv is basically the equivalent to deleting the old file, creating the new file, and adding the changes. Isn't it? If so it's gonna have the same problem as I have now.

-- 
Best regards,
Jeremy Morton (Jez)

On 22/04/2023 19:54, rsbecker@nexbridge.com wrote:
> On Saturday, April 22, 2023 2:02 PM, Jeremy Morton wrote:
>> Yes, I know Linus specifically doesn't store file rename info in Git.
>> The trouble is, every now and then, I'll come across a situation where Git doesn't
>> successfully detect that I've renamed a file because I'm doing something like
>> renaming a class at the same time.  So I'll have a file OldClassNameTests.cs and a
>> NewClassNameTests.cs but a bunch of lines in that file have also changed from
>> OldClassName.DoThing() to NewClassName.DoThing().  I can clearly see that this is a
>> rename, but Git sees enough changed content that it doesn't realize it, and puts it in
>> as a delete/add, losing the content history.
>>
>> The standard answer for this is to rename the file in one commit, then make the
>> changes.  That's fine if you know ahead of time you'll want to do this.  However it's a
>> total PITA if you have a bunch of changes and you realize that a rename has caused
>> this problem.  You now have to back out your changes to the renamed file, add the
>> rename, commit it, then re-apply the changes.
>>
>> Could a command be added to git that means you tell Git that counts as a file
>> rename?  Git would add a marker to the staging area that the file has been renamed,
>> and upon commit, would first generate an additional commit for each rename before
>> generating the main commit, ensuring the rename operation counts as an actual
>> rename, and the content's history is maintained.
> 
> Would git mv work in your situation? You can stage changes to the original file, then use git mv. Or use git mv first. The rename shows as staged in any event.
> --Randall
> 
> 
Previous: rsbecker@nexbridge.comNext: rsbecker@nexbridge.com
Message 3 of 24 in “Proposal: tell git a file has been renamed”
  1. Jeremy MortonApr 22, 2023
  2. rsbecker@nexbridge.comApr 22, 2023
  3. Jeremy MortonApr 22, 2023
  4. rsbecker@nexbridge.comApr 22, 2023
  5. Jeremy MortonApr 22, 2023
  6. rsbecker@nexbridge.comApr 22, 2023
  7. Erik Cervin EdinApr 23, 2023
  8. Kristoffer HaugsbakkApr 23, 2023
  9. Chris TorekApr 24, 2023
  10. Jeremy MortonApr 24, 2023
  11. Chris TorekApr 24, 2023
  12. Erik Cervin EdinApr 24, 2023
  13. Jeremy MortonApr 24, 2023
  14. Erik Cervin EdinApr 24, 2023
  15. Jeremy MortonApr 24, 2023
  16. Felipe ContrerasApr 24, 2023
  17. Jacob KellerApr 24, 2023
  18. Felipe ContrerasApr 24, 2023
  19. Jacob KellerApr 26, 2023
  20. Junio C HamanoApr 26, 2023
  21. Erik Cervin EdinMay 11, 2023
  22. Junio C HamanoApr 24, 2023
  23. Junio C HamanoApr 24, 2023
  24. Jeremy MortonApr 24, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.