Re: [PATCH] Allow '+', '-' and '.' in remote helper names
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Feb 23, 2010, 13:07 UTC
- Message-ID
- <fabb9a1e1002230507i56b32e8cwd7643a79284f6567@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.1002231402350.3980@intel-tinevez-2-302>
Heya,
On Tue, Feb 23, 2010 at 14:03, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> May I caution against allowing "+" as part of filenames? On Windows, > thanks to the DOS garb^Wheritage, "+" is not really allowed...
Would it be safe to say "raplce all occurences of '+' and '.' with '-'? Is it feasible that we would want to support two protocols with a different helper that map to the same 'name' using that scheme? So, would there ever be a case where we want to handle "bzr+ssh" and "bzr-ssh" with a different helper? I reckon not, and if it does occur it's always possible to put a simple dispatcher in between?
-- Cheers, Sverre Rabbelier