Re: [PATCH] Allow '+', '-' and '.' in remote helper names

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 23, 2010, 13:51 UTC
Message-ID: <alpine.DEB.1.00.1002231450010.3980@intel-tinevez-2-302>
In-Reply-To: <fabb9a1e1002230507i56b32e8cwd7643a79284f6567@mail.gmail.com>

Hi,

On Tue, 23 Feb 2010, Sverre Rabbelier wrote:

Show 7 quoted lines

> On Tue, Feb 23, 2010 at 14:03, Johannes Schindelin 
> <Johannes.Schindelin@gmx.de> wrote:
> > May I caution against allowing "+" as part of filenames? On Windows, 
> > thanks to the DOS garb^Wheritage, "+" is not really allowed...
> 
> Would it be safe to say "raplce all occurences of '+' and '.' with
> '-'?

I'd rather only replace '+' with '-'. While "short" DOS filenames can only have one dot, and only up to three (upper-case) characters after that, "long" ones do not share that restriction.

Show 5 quoted lines

> Is it feasible that we would want to support two protocols with a 
> different helper that map to the same 'name' using that scheme? So, 
> would there ever be a case where we want to handle "bzr+ssh" and 
> "bzr-ssh" with a different helper? I reckon not, and if it does occur 
> it's always possible to put a simple dispatcher in between?

Possible.

Ciao, Dscho