Re: [PATCH] Teach 'rebase -i' the command "amend"
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Oct 5, 2009, 21:13 UTC
- Message-ID
- <fabb9a1e0910051413nf8581c8vdf01508d59c4e1a4@mail.gmail.com>
- In-Reply-To
- <7vbpkl8s8x.fsf@alter.siamese.dyndns.org>
Heya,
2009/10/5 Junio C Hamano <gitster@pobox.com>:
> If the rebase insn sheet were richer, and had a way to show the full > message, like this:
But that's not what rebase -i's insn sheet is about is it? It's not "rewrite my commits so that they are the way I want them", it's about "change the order of my commits"/squash some/drop some. The polishing of the commits itself is done after finishing the insn sheet.
> I do not see why we shouldn't allow people to edit any part of the above > to reword.
Because it then becomes very hard to do any actual reordering. I'm not saying it's a bad idea, just that it's a bad idea to do it in 'git rebase -i', conceptually. Although what you suggest would be useful to me, I just think it should be a different command, git rewrite perhaps :P. Definitely not "git rebase -i --rewrite-message" though, becaue it is not at all about rebasing anymore.
-- Cheers, Sverre Rabbelier