[PATCH v3 1/2] shallow: free local object_array allocations
- From
Samo Pogačnik via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jan 10, 2026, 05:13 UTC
- Message-ID
- <f8a8d077cd7203663406bf656287ed7e0d6e6d90.1768022018.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2121.v3.git.git.1768022018.gitgitgadget@gmail.com>
From: =?UTF-8?q?Samo=20Poga=C4=8Dnik?= <samo_pogacnik@t-2.net>
The local object_array 'stack' in get_shallow_commits() function does not free its dynamic elements before the function returns. As a result elements remain allocated and their reference forgotten.
Also note, that test 'fetching deepen beyond merged branch' added by 'shallow: handling fetch relative-deepen' patch fails without this correction in linux-leaks and linux-reftable-leaks test runs.
Signed-off-by: Samo Pogačnik <samo_pogacnik@t-2.net> --- shallow.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/shallow.c b/shallow.c index 55b9cd9d3f..497a25836b 100644 --- a/shallow.c +++ b/shallow.c @@ -198,6 +198,7 @@ struct commit_list *get_shallow_commits(struct object_array *heads, int depth, } } deep_clear_commit_depth(&depths, free_depth_in_slab); + object_array_clear(&stack); return result; }
-- gitgitgadget