Re: [PATCH v4 2/2] shallow: handling fetch relative-deepen

> On Fri, Jan 16, 2026 at 10:31:01PM +0000, Samo Pogačnik via GitGitGadget
> wrote:
> 
> > @@ -881,29 +838,14 @@ static void deepen(struct upload_pack_data *data, int
> > depth)
> >  			struct object *object = data-
> > >shallows.objects[i].item;
> >  			object->flags |= NOT_SHALLOW;
> >  		}
> > -	} else if (data->deepen_relative) {
> > -		struct object_array reachable_shallows = OBJECT_ARRAY_INIT;
> > -		struct commit_list *result;
> > -
> > -		/*
> > -		 * Checking for reachable shallows requires that our refs
> > be
> > -		 * marked with OUR_REF.
> > -		 */
> > -
> > 		refs_head_ref_namespaced(get_main_ref_store(the_repository),
> > -					 check_ref, data);
> > -		for_each_namespaced_ref_1(check_ref, data);
> > -
> > -		get_reachable_list(data, &reachable_shallows);
> > -		result = get_shallow_commits(&reachable_shallows,
> > -					     depth + 1,
> > -					     SHALLOW, NOT_SHALLOW);
> > -		send_shallow(data, result);
> > -		free_commit_list(result);
> > -		object_array_clear(&reachable_shallows);
> >  	} else {
> >  		struct commit_list *result;
> >  
> > -		result = get_shallow_commits(&data->want_obj, depth,
> > +		if (data->deepen_relative)
> > +			get_shallows_depth(data);
> 
> Okay, so here we now essentially call `get_shallow_commits()` twice. The
> first time we compute `data->deepen_relative`, only to then pass it back
> to `get_shallow_commits()` a second time. That feels quite strange to
> me. Can't we have `get_shallow_commits()` handle this for us directly in
> a single call?
> 
> > +		result = get_shallow_commits(&data->want_obj, NULL, NULL,
> > +					     data->deepen_relative + depth,
> >  					     SHALLOW, NOT_SHALLOW);
> >  		send_shallow(data, result);
> >  		free_commit_list(result);
>