Re: [PATCH 00/12] show-ref: introduce mode to check for ref existence
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Oct 25, 2023, 14:44 UTC
- Message-ID
- <f87c95d6-b1e5-45c7-b380-bdc8b8143ab9@gmail.com>
- In-Reply-To
- <CAFQ2z_PqNsz+zycSxz=q2cUVOpJS-AEjwHxEM-fiafxd3dxc9g@mail.gmail.com>
On 25/10/2023 15:26, Han-Wen Nienhuys wrote:
Show 21 quoted lines
> On Tue, Oct 24, 2023 at 9:17 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> Patrick Steinhardt <ps@pks.im> writes: >> >>> this patch series introduces a new `--exists` mode to git-show-ref(1) to >>> explicitly check for the existence of a reference, only. >> >> I agree that show-ref would be the best place for this feature (not >> rev-parse, which is already a kitchen sink). After all, the command >> was designed for validating refs in 358ddb62 (Add "git show-ref" >> builtin command, 2006-09-15). >> >> Thanks. Hopefully I can take a look before I go offline. > > The series description doesn't say why users would care about this. > > If this is just to ease testing, I suggest adding functionality to a > suitable test helper. Anything you add to git-show-ref is a publicly > visible API that needs documentation and comes with a stability > guarantee that is more expensive to maintain than test helper > functionality.
Does the new functionality provide a way for scripts to see if a branch is unborn (i.e. has not commits yet)? I don't think we have a way to distinguish between a ref that points to a missing object and an unborn branch at the moment.
Best Wishes
Phillip