[PATCH v3 04/12] builtin/show-ref: fix dead code when passing patterns
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 31, 2023, 08:16 UTC
- Message-ID
- <4605c6f0ac989b03d25ab02403d6b94836595c43.1698739941.git.ps@pks.im>
- In-Reply-To
- <cover.1698739941.git.ps@pks.im>
When passing patterns to `git show-ref` we have some code that will cause us to die if `verify && !quiet` is true. But because `verify` indicates a different subcommand of git-show-ref(1) that causes us to execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the condition cannot ever be true.
Let's remove this dead code.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- builtin/show-ref.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/builtin/show-ref.c b/builtin/show-ref.c index e55c38af478..f95418d3d16 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -183,11 +183,8 @@ static int cmd_show_ref__patterns(const char **patterns) } else { for_each_ref(show_ref, &show_ref_data); } - if (!found_match) { - if (verify && !quiet) - die("No match"); + if (!found_match) return 1; - } return 0; }
-- 2.42.0