Re: rs/strbuf-addftime-zZ, was Re: What's cooking in git.git (Jun 2017, #04; Tue, 13)

From: René Scharfe <l.s.r@web.de>
Date: Jun 14, 2017, 23:03 UTC
Message-ID: <f80aa20c-dd7e-41e6-f35f-5c633c169732@web.de>
In-Reply-To: <alpine.DEB.2.21.1.1706142303510.171564@virtualbox>

Am 14.06.2017 um 23:04 schrieb Johannes Schindelin:

Show 8 quoted lines

> On Wed, 14 Jun 2017, René Scharfe wrote:
> 
>> Does someone actually expect %z to show time zone names instead of
>> offsets on Windows?
> 
> Not me ;-)
> 
> I cannot speak for anyone else, as I lack that information, though.

Before the patch %z would always expand to +0000 on Linux and to the name of the local time zone on Windows, no matter which offset was actually given. So it was broken in either case (even though it got at least some aspects right by accident for some commits). Based on that I'd think handling %z internally should be OK.

But there's more. strftime on Windows doesn't support common POSIX- defined tokens like %F (%Y-%m-%d) and %T (%H:%M:%S). We could handle them as well. Do we want that? At least we'd have to update the added test that uses them..

Here's the full list of tokens in POSIX [1], but not supported by Windows [2]: %C, %D, %F, %G, %R, %T, %V, %e, %g, %h, %n, %r, %t, %u plus the modifiers %E and %O.

René

[1] http://pubs.opengroup.org/onlinepubs/009695399/functions/strftime.html [2] https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx