git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: rs/strbuf-addftime-zZ, was Re: What's cooking in git.git (Jun 2017, #04; Tue, 13)

From
René Scharfe <l.s.r@web.de>
Date
Jun 15, 2017, 08:46 UTC
Message-ID
<8fc457ea-393b-37fe-c033-beec4128e781@web.de>
In-Reply-To
<20170615054209.yfucmiq3pghxu76j@sigill.intra.peff.net>
Am 15.06.2017 um 07:42 schrieb Jeff King:
Show 17 quoted lines
> On Thu, Jun 15, 2017 at 01:03:29AM +0200, René Scharfe wrote:
>> But there's more.  strftime on Windows doesn't support common POSIX-
>> defined tokens like %F (%Y-%m-%d) and %T (%H:%M:%S). We could handle
>> them as well.  Do we want that?  At least we'd have to update the
>> added test that uses them..
>>
>> Here's the full list of tokens in POSIX [1], but not supported by
>> Windows [2]: %C, %D, %F, %G, %R, %T, %V, %e, %g, %h, %n, %r, %t, %u
>> plus the modifiers %E and %O.
> 
> I don't have a real opinion on that. The point of adding strftime was
> always to give the user access to whatever their system supports. In
> particular "%c" which we cannot emulate ourselves.
> 
> If people want support for those other things on platforms that don't
> have it, I have no real objection. But I also don't know that it's worth
> spending time on if nobody is asking for it.

Agreed; let's make the tests more focused (i.e. not exercise %F and %T needlessly).

René
Previous: Jeff KingNext: Junio C Hamano
Message 12 of 13 in “What's cooking in git.git (Jun 2017, #04; Tue, 13)”
  1. Junio C HamanoJun 13, 2017
  2. Jonathan NiederJun 14, 2017
  3. Junio C HamanoJun 15, 2017
  4. Lars SchneiderJun 14, 2017
  5. Torsten BögershausenJun 14, 2017
  6. rs/strbuf-addftime-zZ, was Re: What's cooking in git.git (Jun 2017, #04; Tue, 13)Johannes Schindelin, Jun 14, 2017
  7. Jeff KingJun 14, 2017
  8. René ScharfeJun 14, 2017
  9. Johannes SchindelinJun 14, 2017
  10. René ScharfeJun 14, 2017
  11. Jeff KingJun 15, 2017
  12. René ScharfeJun 15, 2017
  13. Junio C HamanoJun 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.