Re: rs/strbuf-addftime-zZ, was Re: What's cooking in git.git (Jun 2017, #04; Tue, 13)
- From
René Scharfe <l.s.r@web.de>
- Date
- Jun 15, 2017, 08:46 UTC
- Message-ID
- <8fc457ea-393b-37fe-c033-beec4128e781@web.de>
- In-Reply-To
- <20170615054209.yfucmiq3pghxu76j@sigill.intra.peff.net>
Am 15.06.2017 um 07:42 schrieb Jeff King:
Show 17 quoted lines
> On Thu, Jun 15, 2017 at 01:03:29AM +0200, René Scharfe wrote: >> But there's more. strftime on Windows doesn't support common POSIX- >> defined tokens like %F (%Y-%m-%d) and %T (%H:%M:%S). We could handle >> them as well. Do we want that? At least we'd have to update the >> added test that uses them.. >> >> Here's the full list of tokens in POSIX [1], but not supported by >> Windows [2]: %C, %D, %F, %G, %R, %T, %V, %e, %g, %h, %n, %r, %t, %u >> plus the modifiers %E and %O. > > I don't have a real opinion on that. The point of adding strftime was > always to give the user access to whatever their system supports. In > particular "%c" which we cannot emulate ourselves. > > If people want support for those other things on platforms that don't > have it, I have no real objection. But I also don't know that it's worth > spending time on if nobody is asking for it.
Agreed; let's make the tests more focused (i.e. not exercise %F and %T needlessly).
René