git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] difftool: add env vars directly in run_file_diff()

From
René Scharfe <l.s.r@web.de>
Date
Jun 1, 2024, 20:23 UTC
Message-ID
<f76eaa71-2b04-4d6c-a378-a40010aec22d@web.de>
In-Reply-To
<Zlbf1IY4jFlUPD7e@tanuki>
Am 29.05.24 um 09:57 schrieb Patrick Steinhardt:
Show 9 quoted lines
> On Sun, May 26, 2024 at 10:16:50PM +0200, René Scharfe wrote:
>> Add the environment variables of the child process directly using
>> strvec_push() instead of building an array out of them and then adding
>> that using strvec_pushv().  The new code is shorter and avoids magic
>> array index values and fragile array padding.
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>
> I don't know whether this may cause more allocations.

It doesn't -- strvec_pushv() calls strvec_push() in a loop, the patch just unrolls it.

René
Previous: Patrick Steinhardt
Message 3 of 3 in “difftool: add env vars directly in run_file_diff()”
  1. difftool: add env vars directly in run_file_diff()René Scharfe, May 26, 2024
  2. Patrick SteinhardtMay 29, 2024
  3. René ScharfeJun 1, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.