From: René Scharfe <l.s.r@web.de>
Date: Sat, 01 Jun 2024 20:23:39 GMT
Subject: Re: [PATCH] difftool: add env vars directly in run_file_diff()
Message-ID: <f76eaa71-2b04-4d6c-a378-a40010aec22d@web.de>
In-Reply-To: <Zlbf1IY4jFlUPD7e@tanuki>

Am 29.05.24 um 09:57 schrieb Patrick Steinhardt:
> On Sun, May 26, 2024 at 10:16:50PM +0200, René Scharfe wrote:
>> Add the environment variables of the child process directly using
>> strvec_push() instead of building an array out of them and then adding
>> that using strvec_pushv().  The new code is shorter and avoids magic
>> array index values and fragile array padding.
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>
> I don't know whether this may cause more allocations.

It doesn't -- strvec_pushv() calls strvec_push() in a loop, the
patch just unrolls it.

René