Re: [PATCH v3] ref-filter: trim end whitespace in subject

From: Johannes Sixt <j6t@kdbg.org>
Date: May 22, 2017, 20:19 UTC
Message-ID: <f717824b-3527-251b-bc3f-835f12703698@kdbg.org>
In-Reply-To: <20170522195334.eoj4u4nxupyl6dho@sigill.intra.peff.net>

Am 22.05.2017 um 21:53 schrieb Jeff King:

Show 12 quoted lines

> On Mon, May 22, 2017 at 09:47:59PM +0200, Johannes Sixt wrote:
> 
>> Am 22.05.2017 um 19:10 schrieb DOAN Tran Cong Danh:
>>> diff --git a/t/t3203-branch-output.sh b/t/t3203-branch-output.sh
>>> index 5778c0afe..fa4441868 100755
>>> --- a/t/t3203-branch-output.sh
>>> +++ b/t/t3203-branch-output.sh
>>> @@ -13,7 +13,8 @@ test_expect_success 'make commits' '
>>>    test_expect_success 'make branches' '
>>>    	git branch branch-one &&
>>> -	git branch branch-two HEAD^
>>> +	git branch branch-two $(printf "%s\r\n" one " " line3_long line4 |

I didn't notice earlier that there is a blank between the dq here.

Show 9 quoted lines

>>> +	     git commit-tree HEAD:)
>>>    '
>>>    test_expect_success 'make remote branches' '
>>>
>>
>> This updated test shows nothing, I am afraid: If I apply only this change
>> without the rest of the patch, then all test in t3203 still pass. And I do
>> not see how the code change could make any difference at all. What am I
>> missing?

And I didn't look carefully enough at t3203. Some tests do check branch -v output.

> 
> It does for me here on Linux; I wonder if the CRs are being eaten by the
> shell expansion.

And I tested on Linux, too, but on the wrong branch. On a branch closer to master I see a failure as well. Sorry for the noise.

There are no CRs on the command line, BTW, only on stdin of commit-tree.

-- Hannes