git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] ref-filter: trim end whitespace in subject

From
Johannes Sixt <j6t@kdbg.org>
Date
May 22, 2017, 19:47 UTC
Message-ID
<777c63ed-c1e3-8efd-48cd-91ac2a841631@kdbg.org>
In-Reply-To
<20170522171014.33384-1-congdanhqx@gmail.com>
Am 22.05.2017 um 19:10 schrieb DOAN Tran Cong Danh:
Show 15 quoted lines
> diff --git a/t/t3203-branch-output.sh b/t/t3203-branch-output.sh
> index 5778c0afe..fa4441868 100755
> --- a/t/t3203-branch-output.sh
> +++ b/t/t3203-branch-output.sh
> @@ -13,7 +13,8 @@ test_expect_success 'make commits' '
>   
>   test_expect_success 'make branches' '
>   	git branch branch-one &&
> -	git branch branch-two HEAD^
> +	git branch branch-two $(printf "%s\r\n" one " " line3_long line4 |
> +	     git commit-tree HEAD:)
>   '
>   
>   test_expect_success 'make remote branches' '
>

This updated test shows nothing, I am afraid: If I apply only this change without the rest of the patch, then all test in t3203 still pass. And I do not see how the code change could make any difference at all. What am I missing?

-- Hannes
Previous: DOAN Tran Cong DanhNext: Jeff King
Message 18 of 21 in “[Bug] git branch -v has problems with carriage returns”
  1. Animi VulpisMay 16, 2017
  2. Atousa DupratMay 19, 2017
  3. Animi VulpisMay 19, 2017
  4. Johannes SixtMay 20, 2017
  5. Atousa DupratMay 31, 2017
  6. Stefan BellerMay 31, 2017
  7. Junio C HamanoJun 1, 2017
  8. ref-filter: treat CRLF as same as LF in find_subposDOAN Tran Cong Danh, May 21, 2017
  9. Junio C HamanoMay 22, 2017
  10. DOAN Tran Cong DanhMay 22, 2017
  11. Jeff KingMay 22, 2017
  12. Junio C HamanoMay 23, 2017
  13. Junio C HamanoMay 23, 2017
  14. Junio C HamanoMay 23, 2017
  15. ref-filter: treat CRLF as same as LF in find_subposDOAN Tran Cong Danh, May 21, 2017
  16. ref-filter: trim end whitespace in subjectDOAN Tran Cong Danh, May 22, 2017
  17. ref-filter: trim end whitespace in subjectDOAN Tran Cong Danh, May 22, 2017
  18. Johannes SixtMay 22, 2017
  19. Jeff KingMay 22, 2017
  20. Johannes SixtMay 22, 2017
  21. Atousa DupratMay 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.