git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GITK PATCH 3/3] gitk: strip prefix from filenames in subdirectories

From
KKirill <kirillathome@gmail.com>
Date
Feb 23, 2010, 19:42 UTC
Message-ID
<f579dd581002231142v6a937ac0xdc9618f2a468989d@mail.gmail.com>
In-Reply-To
<alpine.DEB.1.00.1002231811021.3980@intel-tinevez-2-302>
Hi,
On Tue, Feb 23, 2010 at 12:12 PM, Johannes Schindelin wrote:
Show 5 quoted lines
>
> Again in the lower right panel, where the file names of the files touched
> by the current commit are clickable: let's not show the prefix when we
> are in a subdirectory, as it wastes precious screen estate conveying
> information the user already knows.

Unfortunately, it seems to be too aggressive, leading to a misleading display. When gitk is invoked from a subdirectory but without the filter, the lower right panel displays some paths, relative to the root of the work tree, and some, relative to the wd:

$ # fresh netinstall with checked out devel's $ cd / $ gitk --all & # 1 $ cd /bin $ gitk --all & # 2

1. bin/move-wiki.sh when devel is selected; share/WinGit/install.iss -
when installer-improvements is selected (that's correct)
2. move-wiki.sh on devel; share/WinGit/install.iss on installer-improvements
That's misleading.

And honestly, I'm not that advanced in gitk use, so somebody will probably have to do some more testing.

Thanks!

-- Kirill.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 4 of 10 in “gitk: support "gitk <tracheophyte> -- ."”
  1. gitk: support "gitk <tracheophyte> -- ."Johannes Schindelin, Feb 23, 2010
  2. 2/3 gitk: support path filters even in subdirectoriesJohannes Schindelin, Feb 23, 2010
  3. 3/3 gitk: strip prefix from filenames in subdirectoriesJohannes Schindelin, Feb 23, 2010
  4. KirillFeb 23, 2010
  5. Johannes SchindelinFeb 23, 2010
  6. KirillFeb 23, 2010
  7. KirillFeb 23, 2010
  8. Johannes SchindelinFeb 23, 2010
  9. Pat ThoytsFeb 25, 2010
  10. Johannes SchindelinFeb 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.