Re: [GITK PATCH 2/3] gitk: support path filters even in subdirectories
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 25, 2010, 14:22 UTC
- Message-ID
- <alpine.DEB.1.00.1002251427110.3869@intel-tinevez-2-302>
- In-Reply-To
- <a5b261831002241751v5294af48rac8b5f52ba6cb045@mail.gmail.com>
Hi,
On Thu, 25 Feb 2010, Pat Thoyts wrote:
> proc path_filter {filter name} {
> set name [file normalize $name]I am unconvinced that [file normalize] is what we want. It expands to an absolute path, which is almost certainly unnecessary code churn.
I will have a look at your test cases and try to fix later.
Ciao, Johannes