Re: [PATCH v12 0/2] diff-files: integrate with sparse index

From: Victoria Dye <vdye@github.com>
Date: May 11, 2023, 03:41 UTC
Message-ID: <f51a8d77-c480-f021-38c4-78a9d75cdd11@github.com>
In-Reply-To: <20230509194241.469477-1-cheskaqiqi@gmail.com>

Shuqi Liang wrote:

Show 14 quoted lines

> * Add the '--' in all test to remain consistent.
> 
> * Change 'may not' to 'will not'.
> 
> 
> Shuqi Liang (2):
>   t1092: add tests for `git diff-files`
>   diff-files: integrate with sparse index
> 
>  builtin/diff-files.c                     |  4 ++
>  t/perf/p2000-sparse-operations.sh        |  2 +
>  t/t1092-sparse-checkout-compatibility.sh | 66 +++++++++++++++++++++++-
>  3 files changed, 70 insertions(+), 2 deletions(-)
>

This iteration looks good to me. Thanks for keeping up with the reviews and getting this to a polished state!

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.