Makefile checks for DarwinPorts / Fink

Hi,

while I was updating the DarwinPorts Portfile for git, I saw some really suspicious lines in the Makefile of Git for DarwinPorts/Fink.

--- snip ---
        ## fink
        ifeq ($(shell test -d /sw/lib && echo y),y)
                ALL_CFLAGS += -I/sw/include
                ALL_LDFLAGS += -L/sw/lib
        endif
        ## darwinports
        ifeq ($(shell test -d /opt/local/lib && echo y),y)
                ALL_CFLAGS += -I/opt/local/include
                ALL_LDFLAGS += -L/opt/local/lib
        endif
--- snap ---

IMHO, Git should definetely not include /sw/include and /sw/lib, just if it *exists*.

Think of a situation, when somebody has Fink and DarwinPorts installed on one machine (possible). Then if you would build Git from DarwinPorts, the git Makefile would link against Fink libraries! IMHO the DarwinPorts / Fink build process should set LDFLAGS and CFLAGS accordingly.

Also, maybe you want to create a DarwinPorts / Fink independent Mac OS X pkg which contains Git and its deps.

I know this just appends to CFLAGS/LDFLAGS, but if for example DarwinPorts has broken build-deps, then the Fink stuff would get sucked in, and you would not notice. (on a box with both, DP and Fink installed)

bye

Stefan

  --
       http://www.dreamind.de/
Oroborus and Debian GNU/Linux Developer.