Re: Makefile checks for DarwinPorts / Fink

From: Junio C Hamano <junkio@cox.net>
Date: Jul 22, 2006, 14:43 UTC
Message-ID: <7vhd19itu2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <f3d7535d0607210758m4410cddfw16329ce473404fd8@mail.gmail.com>

"Stefan Pfetzing" <stefan.pfetzing@gmail.com> writes:

Show 18 quoted lines

> while I was updating the DarwinPorts Portfile for git, I saw some
> really suspicious lines in the Makefile of Git for DarwinPorts/Fink.
>
> --- snip ---
>        ## fink
>        ifeq ($(shell test -d /sw/lib && echo y),y)
>                ALL_CFLAGS += -I/sw/include
>                ALL_LDFLAGS += -L/sw/lib
>        endif
>        ## darwinports
>        ifeq ($(shell test -d /opt/local/lib && echo y),y)
>                ALL_CFLAGS += -I/opt/local/include
>                ALL_LDFLAGS += -L/opt/local/lib
>        endif
> --- snap ---
>
> IMHO, Git should definetely not include /sw/include and /sw/lib, just
> if it *exists*.

Could you make a concrete suggestion (I am not on Darwin)?

If I am reading you correctly, your suggestion is that DarwinPorts and/or Fink build procedure, which drive our Makefile from outside, should set up CFLAGS and LDFLAGS to have the correct paths for local libraries and headers. It is not clear to me if having these defaults there makes it hard (or cumbersome) to override them in such a setup and you are proposing to remove them (or commenting them out), or if you can live with them being there.

These were made as "quick relatively sane defaults for help people with simple configuration when people build git themselves" initially and it may be the case that they now could use improvements. I dunno (I am not on Darwin).

But I suspect that the "official" portfile (or whatever it is called in the Darwin world) should be able to override whatever is done in there --- otherwise we would need to remove them or comment them out, but I am hoping it does not have to come to that; I think they serve as good hint to help people who are building from the source.