git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/2] Ensure consistent usage of mergetool.keepBackup in git-gui

From
Ferry Huberts <ferry.huberts@pelagic.nl>
Date
Apr 10, 2009, 19:33 UTC
Message-ID
<f3d401fbaec1556ffbf8c13b83e58849af973a71.1239376248.git.ferry.huberts@pelagic.nl>

In several places merge.keepBackup is used i.s.o. mergetool.keepBackup. This patch makes it all consistent for git-gui

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
---
Based on pu

Shawn, I think you said you already applied this, I'm still resending to keep the series complete.

 git-gui/git-gui.sh        |    2 +-
 git-gui/lib/mergetool.tcl |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index e018e07..e4e643a 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -699,7 +699,7 @@ proc apply_config {} {
 
 set default_config(branch.autosetupmerge) true
 set default_config(merge.tool) {}
-set default_config(merge.keepbackup) true
+set default_config(mergetool.keepbackup) true
 set default_config(merge.diffstat) true
 set default_config(merge.summary) false
 set default_config(merge.verbosity) 2
diff --git a/git-gui/lib/mergetool.tcl b/git-gui/lib/mergetool.tcl
index eb2b4b5..b7263b3 100644
--- a/git-gui/lib/mergetool.tcl
+++ b/git-gui/lib/mergetool.tcl
@@ -382,7 +382,7 @@ proc merge_tool_finish {fd} {
 		delete_temp_files $mtool_tmpfiles
 		ui_status [mc "Merge tool failed."]
 	} else {
-		if {[is_config_true merge.keepbackup]} {
+		if {[is_config_true mergetool.keepbackup]} {
 			file rename -force -- $backup "$mtool_target.orig"
 		}
 
-- 
1.6.0.6
Next: Ferry Huberts
Message 1 of 7 in “Ensure consistent usage of mergetool.keepBackup in git-gui”
  1. 1/2 Ensure consistent usage of mergetool.keepBackup in git-guiFerry Huberts, Apr 10, 2009
  2. 2/2 Ensure consistent usage of mergetool.keepBackup in gitFerry Huberts, Apr 10, 2009
  3. Junio C HamanoApr 11, 2009
  4. Ferry Huberts (Pelagic)Apr 11, 2009
  5. Ferry Huberts (Pelagic)Apr 11, 2009
  6. Junio C HamanoApr 11, 2009
  7. Ferry Huberts (Pelagic)Apr 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.