Re: [PATCH v3 2/2] Ensure consistent usage of mergetool.keepBackup in git

From: Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date: Apr 11, 2009, 19:44 UTC
Message-ID: <49E0F33B.8070806@pelagic.nl>
In-Reply-To: <49E0F27C.8070203@pelagic.nl>

Ferry Huberts (Pelagic) wrote:

Show 24 quoted lines

> Junio C Hamano wrote:
>> Ferry Huberts <ferry.huberts@pelagic.nl> writes:
>>
>>> In several places merge.keepBackup is used i.s.o.
>>> mergetool.keepBackup. This patch makes it all
>>> consistent for git
>> A silly question.  The above makes it sound as if both merge.keepBackup
>> and mergetool.keepBackup are valid, but the latter is preferred, and your
>> patch makes things consistent even though without it there is nothing
>> broken per-se.
>>
>> Is that really is the case?
>>
>> Otherwise, perhaps the title and the message should read like this:
>>
>>     Fix misspelled mergetool.keepBackup
>>     
>>     In several places mergetool.keepBackup was misspelled as merge.keepBackup.
>>     
>>     Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
> 
> feel free to change it :-)
> imho there has been way too much discussion for such a simple patch.
>

replying to myself :-)

maybe 'way too much' is a bit strong. I think the part of the discussion about finding out what actually to do was good. the rest was a bit too much for my taste. but I'm still getting used to ways of the git.devel list :-)