git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Mar 3, 2019, 19:11 UTC
Message-ID
<f38ebc4c-f0a6-c57b-1d0e-8208ff638a73@gmail.com>
In-Reply-To
<xmqqef7o3fl8.fsf@gitster-ct.c.googlers.com>
Hi Junio
On 03/03/2019 01:35, Junio C Hamano wrote:
Show 8 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
>> Thanks for explaining, it all makes sense to me now
> 
> It would be necessary to make sure that it all makes sense to all
> future readers.  Are they patches good enough as-is for that, or do
> they need some updates before I take a look at them to pick up?
> 
I've just re-read them and I think they're fine as is, though the first
 paragraph of the first commit message might be clearer if "HEAD was an
ancestor and" was changed to "HEAD was an ancestor of onto and".
Best Wishes
Phillip
Previous: Johannes SchindelinNext: Johannes Schindelin via GitGitGadget
Message 11 of 16 in “Fix ORIG_HEAD behavior of the built-in rebase”
  1. 0/4 Fix ORIG_HEAD behavior of the built-in rebaseJohannes Schindelin via GitGitGadget, Feb 28, 2019
  2. 3/4 built-in rebase: demonstrate that ORIG_HEAD is not set correctlyJohannes Schindelin via GitGitGadget, Feb 28, 2019
  3. 4/4 built-in rebase: set ORIG_HEAD just once, before the rebaseJohannes Schindelin via GitGitGadget, Feb 28, 2019
  4. 2/4 built-in rebase: use the correct reflog when switching branchesJohannes Schindelin via GitGitGadget, Feb 28, 2019
  5. 1/4 built-in rebase: no need to check out `onto` twiceJohannes Schindelin via GitGitGadget, Feb 28, 2019
  6. Phillip WoodFeb 28, 2019
  7. Johannes SchindelinMar 1, 2019
  8. Phillip WoodMar 1, 2019
  9. Junio C HamanoMar 3, 2019
  10. Johannes SchindelinMar 3, 2019
  11. Phillip WoodMar 3, 2019
  12. 0/4 Fix ORIG_HEAD behavior of the built-in rebaseJohannes Schindelin via GitGitGadget, Mar 3, 2019
  13. 1/4 built-in rebase: no need to check out `onto` twiceJohannes Schindelin via GitGitGadget, Mar 3, 2019
  14. 2/4 built-in rebase: use the correct reflog when switching branchesJohannes Schindelin via GitGitGadget, Mar 3, 2019
  15. 3/4 built-in rebase: demonstrate that ORIG_HEAD is not set correctlyJohannes Schindelin via GitGitGadget, Mar 3, 2019
  16. 4/4 built-in rebase: set ORIG_HEAD just once, before the rebaseJohannes Schindelin via GitGitGadget, Mar 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.