git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] built-in rebase: use the correct reflog when switching branches

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 28, 2019, 15:27 UTC
Message-ID
<b92d76065d92cb7003dd9d69525a1ed790a93921.1551367664.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.153.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
By mistake, we used the reflog intended for ORIG_HEAD.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 builtin/rebase.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 813ec284ca..aa469ec964 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -475,7 +475,7 @@ static int reset_head(struct object_id *oid, const char *action,
 				 detach_head ? REF_NO_DEREF : 0,
 				 UPDATE_REFS_MSG_ON_ERR);
 	else {
-		ret = update_ref(reflog_orig_head, switch_to_branch, oid,
+		ret = update_ref(reflog_head, switch_to_branch, oid,
 				 NULL, 0, UPDATE_REFS_MSG_ON_ERR);
 		if (!ret)
 			ret = create_symref("HEAD", switch_to_branch,
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 4 of 16 in “Fix ORIG_HEAD behavior of the built-in rebase”
  1. 0/4 Fix ORIG_HEAD behavior of the built-in rebaseJohannes Schindelin via GitGitGadget, Feb 28, 2019
  2. 3/4 built-in rebase: demonstrate that ORIG_HEAD is not set correctlyJohannes Schindelin via GitGitGadget, Feb 28, 2019
  3. 4/4 built-in rebase: set ORIG_HEAD just once, before the rebaseJohannes Schindelin via GitGitGadget, Feb 28, 2019
  4. 2/4 built-in rebase: use the correct reflog when switching branchesJohannes Schindelin via GitGitGadget, Feb 28, 2019
  5. 1/4 built-in rebase: no need to check out `onto` twiceJohannes Schindelin via GitGitGadget, Feb 28, 2019
  6. Phillip WoodFeb 28, 2019
  7. Johannes SchindelinMar 1, 2019
  8. Phillip WoodMar 1, 2019
  9. Junio C HamanoMar 3, 2019
  10. Johannes SchindelinMar 3, 2019
  11. Phillip WoodMar 3, 2019
  12. 0/4 Fix ORIG_HEAD behavior of the built-in rebaseJohannes Schindelin via GitGitGadget, Mar 3, 2019
  13. 1/4 built-in rebase: no need to check out `onto` twiceJohannes Schindelin via GitGitGadget, Mar 3, 2019
  14. 2/4 built-in rebase: use the correct reflog when switching branchesJohannes Schindelin via GitGitGadget, Mar 3, 2019
  15. 3/4 built-in rebase: demonstrate that ORIG_HEAD is not set correctlyJohannes Schindelin via GitGitGadget, Mar 3, 2019
  16. 4/4 built-in rebase: set ORIG_HEAD just once, before the rebaseJohannes Schindelin via GitGitGadget, Mar 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.