git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: comparing file contents in is_exact_match?

From
YLYakov Lerner <iler.ml@gmail.com>
Date
Jul 17, 2006, 20:32 UTC
Message-ID
<f36b08ee0607171332k1da1ef77j352b31c78039d06c@mail.gmail.com>
In-Reply-To
<17595.48003.145000.414361@lapjr.intranet.kiel.bmiag.de>
On 7/17/06, Juergen Ruehle <j.ruehle@bmiag.de> wrote:
Show 11 quoted lines
> Johannes Schindelin writes:
>  > > > It is not Cygwin really. It's windows. You can't rename or delete an
>  > > > open or mmapped file in that thing.
>  > >
>  > > And GIT's workaround is to read the whole file into memory and close
>  > > it after that?  Uh-oh.
>  >
>  > If you have a better idea (which does not make git source code ugly), go
>  > ahead, write a patch.
>
> On several boxes I've tested the mmap code passes the tests on NTFS.

On me, it failed me on git-apply with more than 1 patches on the commandline.

git-apply with 1 patch on the commandline passed, with two, failed.

git-apply with two patches on commandline is the simplest testcase that exposes this problem, AFAIK.

Yakov
Previous: Juergen RuehleNext: Juergen Ruehle
Message 29 of 32 in “comparing file contents in is_exact_match?”
  1. Martin WaitzJul 6, 2006
  2. Junio C HamanoJul 6, 2006
  3. Martin WaitzJul 6, 2006
  4. Junio C HamanoJul 6, 2006
  5. Martin WaitzJul 6, 2006
  6. Martin WaitzJul 6, 2006
  7. Florian WeimerJul 7, 2006
  8. Johannes SchindelinJul 8, 2006
  9. Florian WeimerJul 16, 2006
  10. Johannes SchindelinJul 16, 2006
  11. Yakov LernerJul 16, 2006
  12. Alex RiesenJul 16, 2006
  13. Florian WeimerJul 17, 2006
  14. Johannes SchindelinJul 17, 2006
  15. Linus TorvaldsJul 17, 2006
  16. Johannes SchindelinJul 17, 2006
  17. Linus TorvaldsJul 17, 2006
  18. Martin WaitzJul 17, 2006
  19. Alex RiesenJul 17, 2006
  20. Geert BoschJul 17, 2006
  21. Linus TorvaldsJul 17, 2006
  22. Yakov LernerJul 18, 2006
  23. Johannes SchindelinJul 18, 2006
  24. Linus TorvaldsJul 18, 2006
  25. Alex RiesenJul 18, 2006
  26. Juergen RuehleJul 17, 2006
  27. Johannes SchindelinJul 17, 2006
  28. Juergen RuehleJul 17, 2006
  29. Yakov LernerJul 17, 2006
  30. Juergen RuehleJul 17, 2006
  31. Yakov LernerJul 18, 2006
  32. Yakov LernerJul 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.