From: Yakov Lerner Date: Mon, 17 Jul 2006 20:32:42 GMT Subject: Re: comparing file contents in is_exact_match? Message-ID: In-Reply-To: <17595.48003.145000.414361@lapjr.intranet.kiel.bmiag.de> On 7/17/06, Juergen Ruehle wrote: > Johannes Schindelin writes: > > > > It is not Cygwin really. It's windows. You can't rename or delete an > > > > open or mmapped file in that thing. > > > > > > And GIT's workaround is to read the whole file into memory and close > > > it after that? Uh-oh. > > > > If you have a better idea (which does not make git source code ugly), go > > ahead, write a patch. > > On several boxes I've tested the mmap code passes the tests on NTFS. On me, it failed me on git-apply with more than 1 patches on the commandline. git-apply with 1 patch on the commandline passed, with two, failed. git-apply with two patches on commandline is the simplest testcase that exposes this problem, AFAIK. Yakov