[PATCH v2 08/11] t6423: add an explanation about why one of the tests does not pass

From: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date: Aug 8, 2020, 17:01 UTC
Message-ID: <f2d7e744fcd6ef24b8cfdbd837e61c420b0712f7.1596906081.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.827.v2.git.git.1596906081.gitgitgadget@gmail.com>

From: Elijah Newren <newren@gmail.com>

While we're at it, document why one of the two tests doesn't pass (since I had long since forgotten it)...though the reasoning makes me question why it's considered a failure at all. Maybe I had a good reason when I introduced it, or maybe I just wasn't looking at it clearly? Either way, the explanation may help a future reader.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t6423-merge-rename-directories.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/t/t6423-merge-rename-directories.sh b/t/t6423-merge-rename-directories.sh
index bd0f17a3be..2b4a482277 100755
--- a/t/t6423-merge-rename-directories.sh
+++ b/t/t6423-merge-rename-directories.sh
@@ -2843,6 +2843,14 @@ test_expect_success '9f: Renamed directory that only contained immediate subdirs
 #   Commit A: priority/{alpha,bravo}/$more_files
 #   Commit B: goal/{a,b}/$more_files, goal/c
 #   Expected: priority/{alpha,bravo}/$more_files, priority/c
+# We currently fail this test because the directory renames we detect are
+#   goal/a/ -> priority/alpha/
+#   goal/b/ -> priority/bravo/
+# We do not detect
+#   goal/   -> priority/
+# because of no files found within goal/, and the fact that "a" != "alpha"
+# and "b" != "bravo".  But I'm not sure it's really a failure given that
+# viewpoint...
 
 test_setup_9g () {
 	test_create_repo 9g &&

-- 
gitgitgadget