Re: [PATCH v2 04/11] t6416, t6422: fix incorrect untracked file count
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 9, 2020, 03:12 UTC
- Message-ID
- <CAPig+cTgYv+UJauyL_o5AeYeCS=aKi_PS4VZ0Q6yH7bZk+Vg=w@mail.gmail.com>
- In-Reply-To
- <9ce80f2f943278fcb8ef46fd1a9507d832657246.1596906081.git.gitgitgadget@gmail.com>
On Sat, Aug 8, 2020 at 1:01 PM Elijah Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:
> Apparently I don't know how to count untracked files, and since the tests
> in question were marked as test_expect_failure, no one every noticed it
> until know. Correct the count, as these tests clearly creates three
> untracked files ('out', 'err', and 'file_count').s/every/ever/ s/know/now/ s/creates/create/
Show 7 quoted lines
> (I believe this problem arose because earlier incarnations counted lines > via a pipe to 'wc -l'. Reviewers asked that it be replaced by writing > the output to a file and using test_line_count, but when the temporary > output was added to a separate file, the count of untracked files should > have increased.) > > Signed-off-by: Elijah Newren <newren@gmail.com>