git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 04/11] t6416, t6422: fix incorrect untracked file count

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 9, 2020, 03:12 UTC
Message-ID
<CAPig+cTgYv+UJauyL_o5AeYeCS=aKi_PS4VZ0Q6yH7bZk+Vg=w@mail.gmail.com>
In-Reply-To
<9ce80f2f943278fcb8ef46fd1a9507d832657246.1596906081.git.gitgitgadget@gmail.com>

On Sat, Aug 8, 2020 at 1:01 PM Elijah Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:

> Apparently I don't know how to count untracked files, and since the tests
> in question were marked as test_expect_failure, no one every noticed it
> until know.  Correct the count, as these tests clearly creates three
> untracked files ('out', 'err', and 'file_count').

s/every/ever/ s/know/now/ s/creates/create/

Show 7 quoted lines
> (I believe this problem arose because earlier incarnations counted lines
> via a pipe to 'wc -l'.  Reviewers asked that it be replaced by writing
> the output to a file and using test_line_count, but when the temporary
> output was added to a separate file, the count of untracked files should
> have increased.)
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren
Message 6 of 28 in “Collect merge-related tests to t64xx”
  1. Collect merge-related tests to t64xxElijah Newren via GitGitGadget, Aug 5, 2020
  2. 00/11 Start preparing merge-related tests to work with multiple merge backendsElijah Newren via GitGitGadget, Aug 8, 2020
  3. 02/11 t6418: tighten delete/normalize conflict testcaseElijah Newren via GitGitGadget, Aug 8, 2020
  4. 01/11 Collect merge-related tests to t64xxElijah Newren via GitGitGadget, Aug 8, 2020
  5. 04/11 t6416, t6422: fix incorrect untracked file countElijah Newren via GitGitGadget, Aug 8, 2020
  6. Eric SunshineAug 9, 2020
  7. Elijah NewrenAug 9, 2020
  8. 05/11 t6423: fix test setup for a couple testsElijah Newren via GitGitGadget, Aug 8, 2020
  9. 09/11 t6422, t6426: be more flexible for add/add conflicts involving renamesElijah Newren via GitGitGadget, Aug 8, 2020
  10. 10/11 t642[23]: be more flexible for add/add conflicts involving pair renamesElijah Newren via GitGitGadget, Aug 8, 2020
  11. 08/11 t6423: add an explanation about why one of the tests does not passElijah Newren via GitGitGadget, Aug 8, 2020
  12. 11/11 t6425: be more flexible with rename/delete conflict messagesElijah Newren via GitGitGadget, Aug 8, 2020
  13. 07/11 t6416, t6423: clarify some comments and fix some typosElijah Newren via GitGitGadget, Aug 8, 2020
  14. 06/11 t6422: fix multiple errors with the mod6 test expectationsElijah Newren via GitGitGadget, Aug 8, 2020
  15. 03/11 t6422: fix bad check against missing fileElijah Newren via GitGitGadget, Aug 8, 2020
  16. Eric SunshineAug 9, 2020
  17. 00/11 Start preparing merge-related tests to work with multiple merge backendsElijah Newren via GitGitGadget, Aug 10, 2020
  18. 01/11 Collect merge-related tests to t64xxElijah Newren via GitGitGadget, Aug 10, 2020
  19. 05/11 t6423: fix test setup for a couple testsElijah Newren via GitGitGadget, Aug 10, 2020
  20. 06/11 t6422: fix multiple errors with the mod6 test expectationsElijah Newren via GitGitGadget, Aug 10, 2020
  21. 07/11 t6416, t6423: clarify some comments and fix some typosElijah Newren via GitGitGadget, Aug 10, 2020
  22. 08/11 t6423: add an explanation about why one of the tests does not passElijah Newren via GitGitGadget, Aug 10, 2020
  23. 09/11 t6422, t6426: be more flexible for add/add conflicts involving renamesElijah Newren via GitGitGadget, Aug 10, 2020
  24. 04/11 t6416, t6422: fix incorrect untracked file countElijah Newren via GitGitGadget, Aug 10, 2020
  25. 10/11 t642[23]: be more flexible for add/add conflicts involving pair renamesElijah Newren via GitGitGadget, Aug 10, 2020
  26. 02/11 t6418: tighten delete/normalize conflict testcaseElijah Newren via GitGitGadget, Aug 10, 2020
  27. 11/11 t6425: be more flexible with rename/delete conflict messagesElijah Newren via GitGitGadget, Aug 10, 2020
  28. 03/11 t6422: fix bad check against missing fileElijah Newren via GitGitGadget, Aug 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.