unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.]

From: René Scharfe <l.s.r@web.de>
Date: Jan 13, 2018, 17:13 UTC
Message-ID: <f139ed79-1e12-d7b6-dd24-ce77000917ec@web.de>
In-Reply-To: <004c01d38bde$f0e6bb50$d2b431f0$@nexbridge.com>

Am 12.01.2018 um 20:52 schrieb Randall S. Becker:

> On a related too many warnings subject, hashmap.h has a variable
> unused (void *item). Is that addressed soon? If not, I can deal with
> it.

Here are the code lines containing the variable in question:

        void *item;
        while ((item = hashmap_iter_next(&iter)))

Intriguing. The variable "item" is set, but can be removed without effect. GCC 7.2 and Clang 5 don't warn about that.

The code was introduced by 8b604d1951 (hashmap: add API to disable item counting when threaded) and there is no patch in pu that touches it again, yet.

René