git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fixed pervasive enumeration warning in convert.h.

From
Rrandall.s.becker@rogers.com <randall.s.becker@rogers.com>
Date
Jan 12, 2018, 16:36 UTC
Message-ID
<20180112163644.14108-1-randall.s.becker@rogers.com>
From: "Randall S. Becker" <rsbecker@nexbridge.com>

The actual enum value should be used rather than 0 and was causing a warning in an inline proc.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 convert.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/convert.h b/convert.h
index 4f2da22..a9a6658 100644
--- a/convert.h
+++ b/convert.h
@@ -79,7 +79,7 @@ extern int renormalize_buffer(const struct index_state *istate,
 static inline int would_convert_to_git(const struct index_state *istate,
 				       const char *path)
 {
-	return convert_to_git(istate, path, NULL, 0, NULL, 0);
+	return convert_to_git(istate, path, NULL, 0, NULL, SAFE_CRLF_FALSE);
 }
 /* Precondition: would_convert_to_git_filter_fd(path) == true */
 extern void convert_to_git_filter_fd(const struct index_state *istate,
-- 
2.8.5.23.g6fa7ec3
Next: Junio C Hamano
Message 1 of 6 in “Fixed pervasive enumeration warning in convert.h.”
  1. Fixed pervasive enumeration warning in convert.h.randall.s.becker@rogers.com, Jan 12, 2018
  2. Junio C HamanoJan 12, 2018
  3. Randall S. BeckerJan 12, 2018
  4. unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.]René Scharfe, Jan 13, 2018
  5. Randall S. BeckerJan 13, 2018
  6. 1/1 convert_to_git(): safe_crlf/checksafe becomes int conv_flagstboegi@web.de, Jan 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.