git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] update_unicode.sh: update the uniset repo if it exists

From
Beat Bolli <dev+git@drbeat.li>
Date
Dec 12, 2016, 19:24 UTC
Message-ID
<f068b579-fb1a-447b-283b-006686b90861@drbeat.li>
In-Reply-To
<ca10a51a-0fab-e4a4-8d7d-035673af4c06@web.de>
On 12.12.16 19:12, Torsten Bögershausen wrote:
Show 32 quoted lines
> 
>>> Minor question, especially to the next commit:
>>> Should we make sure to checkout the exact version, which has been tested?
>>> In this case  cb97792880625e24a9f581412d03659091a0e54f
>>>
>>> And this is for both a fresh clone and the git pull
>>> needs to be replaced by
>>> git fetch && git checkout cb97792880625e24a9f581412d03659091a0e54f
>>>
>>>
>>> (Which of course is a shell variable)
>>
>> I was actually wondering what the policy was for adding submodules to the Git repo,
>> but then decided against it. Another option would be to fork uniset on GitHub and
>> just let it stay on a working commit.
>>
>> Junio, what's your stance on this?
>>
>> Beat
> 
> If I run  ./update_unicode.sh on the latest master of   https://github.com/depp/uniset.git ,
> commit  a5fac4a091857dd5429cc2d, I get a diff in  unicode_width.h like this:
> 
> -{ 0x0300, 0x036F },
> 
> +{ 768, 879 },
> 
> IOW, all hex values are printed as decimal values.
> Not a problem for the compiler, but for the human
> to check the unicode tables.
> 
> So I think we should "pin" the version of uniset.
That's what patch 3/3 fixes.
Previous: Junio C Hamano
Message 11 of 11 in “update_unicode.sh: update the uniset repo if it exists”
  1. 1/3 update_unicode.sh: update the uniset repo if it existsBeat Bolli, Dec 11, 2016
  2. 2/3 update_unicode.sh: remove the plane filtersBeat Bolli, Dec 11, 2016
  3. 3/3 update_unicode.sh: restore hexadecimal outputBeat Bolli, Dec 11, 2016
  4. Torsten BögershausenDec 12, 2016
  5. Beat BolliDec 12, 2016
  6. Torsten BögershausenDec 12, 2016
  7. Junio C HamanoDec 12, 2016
  8. Beat BolliDec 12, 2016
  9. Torsten BögershausenDec 13, 2016
  10. Junio C HamanoDec 13, 2016
  11. Beat BolliDec 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.