Re: [PATCH 1/3] update_unicode.sh: update the uniset repo if it exists

From: Torsten Bögershausen <tboegi@web.de>
Date: Dec 13, 2016, 06:16 UTC
Message-ID: <d91b5e69-9b90-e21e-0dcb-8eace00ddd74@web.de>
In-Reply-To: <954eed6b-c899-4f4c-eb3d-2b6d2ff4385d@drbeat.li>

Show 21 quoted lines

>> Sure, and I'd rather see the update-unicode.sh script moved
>> somewhere in contrib/ while at it.  Those who are interested in
>> keeping up with the unicode standard are tiny minority of the
>> developer population, and most of us would treat the built width
>> table as the source (after all, that is what we ship).
>>
>> To be bluntly honest, I'd rather not to see "update-unicode.sh"
>> download and build uniset at all.  It's as if po/ hierarchy shipping
>> with its own script to download and build msgmerge--that's madness.
>> Needless to say, shipping the sources for uniset embedded in our
>> project tree (either as a snapshot-fork or as a submodule) is even
>> worse.  Those who want to muck with po/ are expected to have
>> msgmerge and friends.  Why not expect the same for those who want to
>> update the unicode width table?
>>
>> I'd rather see a written instruction telling which snapshot to get
>> and from where to build and place on their $PATH in the README file,
>> sitting next to the update-unicode.sh script in contrib/uniwidth/
>> directory, for those who are interested in building the width table
>> "from the source", and the update-unicode.sh script to assume that
>> uniset is available.

OK with the contrib - that's an improvement. About the instructions how to download and compile: (we don't need to change the $PATH, do we ?) I don't know. The typical instructions I have seen are a sequence of shell commands to be executed, which hopefully simply work by doing "copy-and-paste". I find this error-prone, as you you may loose the last character while moving the mouse, or don't check the error message or return codes. Having a pre-baked shell script, which does use "&&" is in that way more attractive, and the README can be as simple as run "update-unicode.sh" and that's it.

uniset is a small project and where should we put it ? a) inside the Git tree? b) /tmp ? c) into the $HOME directory ? d) /usr/local

a) is quick and dirty b) probably OK c) Not sure about tha d) Needs super user rights Can we try to find a good place ?

"contrib/uniwidth/" may be different to find, how about contrib/update-unicode ?

> OK. So please don't merge bb/unicode-9.0 to next yet; I'll prepare a
> reroll following your description.
>
> Torsten, is this alright with you?

sure

> Cheers, Beat