Re: Possible regression in git-rev-list --header

From: Jakub Narebski <jnareb@gmail.com>
Date: Dec 30, 2006, 18:30 UTC
Message-ID: <en6b34$8ni$1@sea.gmane.org>
In-Reply-To: <e5bfff550612300956mef4691fqf607fad173c571da@mail.gmail.com>

Marco Costalba wrote:

Show 25 quoted lines

> When 'commitencoding' variable is set in config file then git-rev-list
> called with --header option sends also the encoding information.
> 
> $ git rev-list --header -n1 HEAD
> 6d751699cb04150abd79a730187d4e2ed6330c05
> tree 70209eebdc59d108948feb15c3c5497f299ef290
> parent 49a8186d7352d0454df79b289fecb18c8e535c32
> author Marco Costalba <mcostalba@gmail.com> 1167500660 +0100
> committer Marco Costalba <mcostalba@gmail.com> 1167500660 +0100
> encoding UTF-8
> 
>     Test commit
> 
>     Let's see what git-rev-list --header spits out.
> 
>     Signed-off-by: Marco Costalba <mcostalba@gmail.com>
> 
> $ git --version
> git version 1.5.0.rc0.g1ed48
> 
> 
> This is very unfortunate because qgit parsing routine it's totally
> broken after this change. Please revert the patch, or at least make
> git-rev-list --header quiet as default, IOW add an option
> --show-encoding that defaults to disabled.

Well, that is incompatibile change, but it also shows design errors in qgit, as it should ignore unknown headers, and rely on "\n\n" to separate header from the body. Isn't it?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git