Re: Possible regression in git-rev-list --header

From: Lars Hjemli <hjemli@gmail.com>
Date: Jan 3, 2007, 11:14 UTC
Message-ID: <8c5c35580701030314t69b6a7dbhf9cb99de4567b93e@mail.gmail.com>
In-Reply-To: <e5bfff550701030235g6f26044h8dd73e8abe1ec9e3@mail.gmail.com>

On 1/3/07, Marco Costalba <mcostalba@gmail.com> wrote:

Show 12 quoted lines

> On 1/3/07, Lars Hjemli <hjemli@gmail.com> wrote:
> > On 1/3/07, Marco Costalba <mcostalba@gmail.com> wrote:
> > >         - one blank line
> > >         - zero or one line with log title
> > >         - zero or more lines with log message
> > >         - a terminating '\0'
> >
> > I think the should be:
> >   -zero or more blank lines
>
> Isn't it zero or _one_ blank line? Why more then one? would be it
> useful? surely is slower to parse.

My point is just that the log message is unformatted. There is nothing stopping you from adding blank lines at the start of the message.

But then I tested it, and it seems as 'git-commit' strips off any leading blank lines (but git-commit-tree does not). So expecting one blank _might_ be good enough.

>
> >   -zero or more non-blank lines with log title
>
> multi lines titles are allowed? never saw one of them.

It is allowed (I tested this)

Show 8 quoted lines

>
> >   -zero or more blank lines
>
> Why? this is necessary only to disambiguate muti (non blank) lines
> titles, but as Junio pointed out distinction between log title and log
> message is only in the Porcelain, not encoded in git. So the Porcalain
> is going to show _one_line title if any an the remaining stuff in the
> log message.

Well, if the porcelain chooses to do so, it probably is ok. But I think the parsing/presentation of the log title/message would be more correct/better formatted if the parser is more "adaptive" to the content.

-- 
larsh