Re: [PATCH] Stop telling users we are 'defaulting to local storage area'.
Show 12 quoted lines
> Back in the old days of Git when people messed around with their
> GIT_DIR environment variable more often it was nice to know whether
> or not git-init-db created a .git directory or used GIT_DIR.
>
> But now that we are making excuses in the documentation about why
> this message gets printed by git-init-db we should just remove it
> entirely. It doesn't really help the user to understand what just
> happened. It also breaks from our normal behavior of not printing
> anything if the command was successful.
>
> Suggested by Andy Parkins in his Git 'niggles' list
> (<200612132237.10051.andyparkins@gmail.com>).
Perhaps we should print something _if_ GIT_DIR is set, then?
Show 10 quoted lines
> * Set up the default .git directory contents
> */
> git_dir = getenv(GIT_DIR_ENVIRONMENT);
> - if (!git_dir) {
> + if (!git_dir)
> git_dir = DEFAULT_GIT_DIR_ENVIRONMENT;
> - fprintf(stderr, "defaulting to local storage area\n");
> - }
> safe_create_dir(git_dir, 0);
> I'd rather leave block, even if it consist now of single statement.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Jakub Narebski <jnareb@gmail.com>