Shawn O. Pearce[PATCH] Stop telling users we are 'defaulting to local storage area'.
Back in the old days of Git when people messed around with their GIT_DIR environment variable more often it was nice to know whether or not git-init-db created a .git directory or used GIT_DIR.
But now that we are making excuses in the documentation about why this message gets printed by git-init-db we should just remove it entirely. It doesn't really help the user to understand what just happened. It also breaks from our normal behavior of not printing anything if the command was successful.
Suggested by Andy Parkins in his Git 'niggles' list (<200612132237.10051.andyparkins@gmail.com>).
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- Documentation/core-tutorial.txt | 14 +++----------- Documentation/tutorial-2.txt | 1 - Documentation/tutorial.txt | 6 ------ builtin-init-db.c | 4 +--- 4 files changed, 4 insertions(+), 21 deletions(-)
Show changes to 4 files +4 −17
Documentation/core-tutorial.txt, Documentation/tutorial-2.txt, Documentation/tutorial.txt, builtin-init-db.c
diff --git a/Documentation/core-tutorial.txt b/Documentation/core-tutorial.txt index 47505aa..f90c66c 100644 --- a/Documentation/core-tutorial.txt +++ b/Documentation/core-tutorial.txt @@ -54,17 +54,9 @@ $ cd git-tutorial $ git-init-db ------------------------------------------------ -to which git will reply - ----------------- -defaulting to local storage area ----------------- - -which is just git's way of saying that you haven't been doing anything -strange, and that it will have created a local `.git` directory setup for -your new project. You will now have a `.git` directory, and you can -inspect that with `ls`. For your new empty project, it should show you -three entries, among other things: +You will now have a `.git` directory, and you can inspect that with +`ls`. For your new empty project, it should show you three entries, +among other things: - a file called `HEAD`, that has `ref: refs/heads/master` in it. This is similar to a symbolic link and points at diff --git a/Documentation/tutorial-2.txt b/Documentation/tutorial-2.txt index 6389de5..f7f2e1c 100644 --- a/Documentation/tutorial-2.txt +++ b/Documentation/tutorial-2.txt @@ -18,7 +18,6 @@ Let's start a new project and create a small amount of history: $ mkdir test-project $ cd test-project $ git init-db -defaulting to local storage area $ echo 'hello world' > file.txt $ git add . $ git commit -a -m "initial commit" diff --git a/Documentation/tutorial.txt b/Documentation/tutorial.txt index 02dede3..88ace3b 100644 --- a/Documentation/tutorial.txt +++ b/Documentation/tutorial.txt @@ -35,12 +35,6 @@ $ cd project $ git init-db ------------------------------------------------ -Git will reply - ------------------------------------------------- -defaulting to local storage area ------------------------------------------------- - You've now initialized the working directory--you may notice a new directory created, named ".git". Tell git that you want it to track every file under the current directory with (notice the dot '.' diff --git a/builtin-init-db.c b/builtin-init-db.c index 235a0ee..405b9a1 100644 --- a/builtin-init-db.c +++ b/builtin-init-db.c @@ -274,10 +274,8 @@ int cmd_init_db(int argc, const char **argv, const char *prefix) * Set up the default .git directory contents */ git_dir = getenv(GIT_DIR_ENVIRONMENT); - if (!git_dir) { + if (!git_dir) git_dir = DEFAULT_GIT_DIR_ENVIRONMENT; - fprintf(stderr, "defaulting to local storage area\n"); - } safe_create_dir(git_dir, 0); /* Check to see if the repository version is right.
