Re: git-commit: select which files to commit while editing the commit message

From: Jakub Narebski <jnareb@gmail.com>
Date: Dec 8, 2006, 19:32 UTC
Message-ID: <elcegl$qfh$1@sea.gmane.org>
In-Reply-To: <7vpsaui4cn.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 24 quoted lines

> Pazu <pazu@pazu.com.br> writes:
> 
>> # Please enter the commit message for your changes.
>> # (Comment lines starting with '#' will not be included)
>> # On branch refs/heads/next
>> # Updated but not checked in:
>> #   (will commit)
>> #
>> #    modified:   perl/Makefile
>> #    modified:   var.c
>>
>> Here's where the magic would happen. Removing the line "modified: var.c" would
>> remove var.c from this commit. Of course, the template message should be
>> modified to tell the user he can do that.
>>
>> So, what do you think about this?
> 
> Personally, I would refuse to use such a modified git, because
> often the first thing I would do in the commit log buffer is
> check the listed files and remove the '# ...' lines while
> typing.  I do not want that to affect the set of changes I
> staged in any way.
> 
> But maybe that is just me.

I was to raise the same objection.

But this can be solved by using magic _only_ if the template with exception of "modified:" lines matches, and if there is at least one file in "modified:" section.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git