Re: [PATCH] git-add --interactive (wip)

From: Junio C Hamano <junkio@cox.net>
Date: Dec 13, 2006, 05:34 UTC
Message-ID: <7v1wn4mk9i.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612130415.59038.Josef.Weidendorfer@gmx.de>

Josef Weidendorfer <Josef.Weidendorfer@gmx.de> writes:

> No. It currently is starting to get useful. With the ability
> to temporarily store away a dirty state of the working directory,
> it really could become very good.

Hmm, a way to easily stash away local changes and restoring would lead to a system where you can easily stash and unstash multiple snapshots and switch between them, and such a model sounds vaguely familiar...

Show 9 quoted lines

>> > Just as a sidenote: after deciding to not apply hunks, you
>> > lose them in this WIP, as you will find nothing in "unstaged" mode
>> > afterwards :-(
>> 
>> I do not understand this part.  You can 'revert' to match the
>> index to HEAD and run 'patch' to pick what you want again.
>
> I lost my changes in the working directory; there was nothing to
> pick again any more.

That's worrysome. By design, "git add" should not touch working tree at all (only read from there), so if you find cases that violates it that should be fixed; please let me know.