Re: [PATCH/RFC] gitweb: New improved patchset view

From: Anand Kumria <wildfire@progsoc.org>
Date: Oct 29, 2006, 12:44 UTC
Message-ID: <ei27mu$q9s$1@sea.gmane.org>
In-Reply-To: <200610291122.30852.jnareb@gmail.com>

On Sun, 29 Oct 2006 11:22:30 +0100, Jakub Narebski wrote:

Show 16 quoted lines

> You should be able to check new commitdiff view at
>   http://roke_DOT_dyndns_DOT_info/cgi-bin/gitweb/gitweb.cgi
> (URL mangling courtesy vger banned words list, aaaarrghhh)
> if I didn't screwed something again with firewall, and when my machine
> is up; should be for at least an hour. Check for example:
>   ?p=git.git;a=commitdiff;h=origin
>   ?p=git.git;a=commitdiff;h=161332a521fe10c41979bcd493d95e2ac562b7f
>   ?p=git.git;a=commitdiff;h=e12c095aa69d8aca0326eb11960427d9bf9e2db7
>   ?p=git.git;a=commitdiff;h=82560983997c961d9deafe0074b787c8484c2e1d
> and compare to (for example)
>   http://repo.or.cz/w/git.git?a=commitdiff;h=82560983997c961d9deafe0074b787c8484c2e1d
> or (even older gitweb)
>   http://www.kernel.org/git/?p=git/git.git;a=commitdiff;h=887a612fef942dd3e7dae452e2dc582738b0fb41
> BTW. this gitweb has also my previous "Slight improvement" patch applied.
> 
> Do you like it? What should be changed (code, output, style)?

I think your version looks a lot nicer but I believe that the commit message area should be in a fixed-point font. In general it won't be a problem but if anyone should choose to insert a diagram or something else that assume a fixed-width display - it won't look good.

Anand