git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view

From
Jakub Narebski <jnareb@gmail.com>
Date
Oct 30, 2006, 01:21 UTC
Message-ID
<200610300221.58782.jnareb@gmail.com>
In-Reply-To
<7vr6wqy5cb.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 8 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
>> 3. Should we make from-range/to-range in chunk header hyperlink to the 
>> start of given bunch of lines in appropriate file? Or perhaps to the 
>> middle of the bunch of lines? Or to first changed line (omitting 
>> context)?
> 
> I do not see what usage pattern this link would help.  Care to
> explain a bit better?
For example for the following header
diff --git _a/gitweb/gitweb.perl_ _b/gitweb/gitweb.perl_
index _cbab3c9_.._a5a140c_ 100755
--- a/_gitweb/gitweb.perl_
+++ b/_gitweb/gitweb.perl_
@@ _-1255,9_ _+1255,12_ @@ sub parse_difftree_raw_line {

The '-1255,9' would be link to older version of gitweb/gitweb.perl file,
directly to the line #1255 (or to first changed line, or to the middle
of the chunk i.e. 1255+9/2 line).

The '+1255,12' would be link to newer version of file, to line 1255.
-- 
Jakub Narebski
Previous: Junio C Hamano
Message 8 of 8 in “gitweb: New improved patchset view”
  1. gitweb: New improved patchset viewJakub Narebski, Oct 29, 2006
  2. Anand KumriaOct 29, 2006
  3. Luben TuikovOct 29, 2006
  4. Luben TuikovOct 29, 2006
  5. gitweb: New improved patchset viewJakub Narebski, Oct 29, 2006
  6. Jakub NarebskiOct 30, 2006
  7. Junio C HamanoOct 30, 2006
  8. Jakub NarebskiOct 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.