Re: Question about commit message conventions

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 24, 2006, 14:08 UTC
Message-ID: <ehl6n6$6jn$1@sea.gmane.org>
In-Reply-To: <200610241549.48238.t.toedter@gmx.net>

Tobias Toedter wrote:

Show 15 quoted lines

> Hi,
> 
> although I've read the documentation of git very carefully, I could not find 
> anything related to certain commit message conventions. It would be great 
> if someone here could explain a few things, maybe this could be added to 
> the wiki afterwards (<http://git.or.cz/gitwiki/CommitMessageConventions>).
> 
> First of all, what's the intended use of the "Signed-off-by:" lines? Does it 
> make sense to add my name there, even when I'm listed as the author or 
> committer of a commit? I thought that they are intended mostly to note the 
> approval of other developers.
> 
> On the other hand, concerning the approval of other developers, what's the 
> difference between "Signed-off-by:" and "Acked-by:"? Are there any 
> more "*-by:" fields that are in use?

>From Documentation/SubmittingPatches:

(6) Sign your work [...] The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as a open-source patch.

"Acked-by:" is used to notify that patch was accepted by somebody, which usually is maintainer of part affected by patch.

I have seen exactly on "Cheered-on-by:", and there are probably some "Noticed-by:" there.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git