Re: Question about commit message conventions

From: Erik Mouw <erik@harddisk-recovery.com>
Date: Oct 24, 2006, 14:08 UTC
Message-ID: <20061024140856.GH5639@harddisk-recovery.com>
In-Reply-To: <200610241549.48238.t.toedter@gmx.net>

On Tue, Oct 24, 2006 at 03:49:44PM +0200, Tobias Toedter wrote:

Show 9 quoted lines

> although I've read the documentation of git very carefully, I could not find 
> anything related to certain commit message conventions. It would be great 
> if someone here could explain a few things, maybe this could be added to 
> the wiki afterwards (<http://git.or.cz/gitwiki/CommitMessageConventions>).
> 
> First of all, what's the intended use of the "Signed-off-by:" lines? Does it 
> make sense to add my name there, even when I'm listed as the author or 
> committer of a commit? I thought that they are intended mostly to note the 
> approval of other developers.

See Documentation/SubmittingPatches. You basically say you have the right to submit the patch.

> On the other hand, concerning the approval of other developers, what's the 
> difference between "Signed-off-by:" and "Acked-by:"? Are there any 
> more "*-by:" fields that are in use?

Acked-by is usually used when someone (not the upstream maintainer the patch was send to) agrees with the patch. I.e.: (s)he says the content of the patch is OK without actually acknowledging something about the right to submit.

Erik

-- 
+-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 --
| Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands